arthur/ui
1
0
Fork 0
mirror of https://github.com/ArthurDanjou/ui.git synced 2026-01-18 14:08:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore(NavigationMenu): consistent key for child link external icon

Browse Source
This commit is contained in:
Benjamin Canac
2024-06-04 12:43:09 +02:00
parent e051ef682a
commit b1879ea6d1
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/runtime/components/NavigationMenu.vue
View File

@@ -147,7 +147,7 @@ const lists = computed(() => props.items?.length ? (Array.isArray(props.items[0]
<p :class="ui.childLinkLabel({ active: childActive })">
{{ childItem.label }}
<UIcon v-if="childItem.target === '_blank'" :name="appConfig.ui.icons.external" :class="ui.childLinkExternalIcon({ active: childActive })" />
<UIcon v-if="childItem.target === '_blank'" :name="appConfig.ui.icons.external" :class="ui.childLinkLabelExternalIcon({ active: childActive })" />
</p>
<p v-if="childItem.description" :class="ui.childLinkDescription({ active: childActive })">
{{ childItem.description }}

6
src/theme/navigation-menu.ts
View File

@@ -15,10 +15,10 @@ export default (config: { colors: string[] }) => ({
childItem: '',
childLink: 'group size-full px-3 py-2 rounded-md flex items-start gap-2 text-left',
childLinkWrapper: 'flex flex-col items-start',
childLinkLabel: 'font-semibold text-sm relative inline-flex',
childLinkDescription: 'text-sm text-gray-500 dark:text-gray-400',
childLinkIcon: 'size-5 shrink-0',
childLinkExternalIcon: 'size-3 align-top text-gray-400 dark:text-gray-500',
childLinkLabel: 'font-semibold text-sm relative inline-flex',
childLinkLabelExternalIcon: 'size-3 align-top text-gray-400 dark:text-gray-500',
childLinkDescription: 'text-sm text-gray-500 dark:text-gray-400',
separator: 'px-2 h-px bg-gray-200 dark:bg-gray-800',
viewportWrapper: 'absolute top-full inset-x-0 flex w-full',
// FIXME: add `sm:w-[var(--radix-navigation-menu-viewport-width)]` / `transition-[width,height]` / `origin-[top_center]` once position is based on trigger