From b1879ea6d184cb51cac4ccaafea26885343b02c5 Mon Sep 17 00:00:00 2001
From: Benjamin Canac <canacb1@gmail.com>
Date: Tue, 4 Jun 2024 12:43:09 +0200
Subject: [PATCH] chore(NavigationMenu): consistent key for child link external
 icon

---
 src/runtime/components/NavigationMenu.vue | 2 +-
 src/theme/navigation-menu.ts              | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/runtime/components/NavigationMenu.vue b/src/runtime/components/NavigationMenu.vue
index ce88d2a6..15b8839c 100644
--- a/src/runtime/components/NavigationMenu.vue
+++ b/src/runtime/components/NavigationMenu.vue
@@ -147,7 +147,7 @@ const lists = computed(() => props.items?.length ? (Array.isArray(props.items[0]
                           <p :class="ui.childLinkLabel({ active: childActive })">
                             {{ childItem.label }}
 
-                            <UIcon v-if="childItem.target === '_blank'" :name="appConfig.ui.icons.external" :class="ui.childLinkExternalIcon({ active: childActive })" />
+                            <UIcon v-if="childItem.target === '_blank'" :name="appConfig.ui.icons.external" :class="ui.childLinkLabelExternalIcon({ active: childActive })" />
                           </p>
                           <p v-if="childItem.description" :class="ui.childLinkDescription({ active: childActive })">
                             {{ childItem.description }}
diff --git a/src/theme/navigation-menu.ts b/src/theme/navigation-menu.ts
index 80940969..8c23ba0c 100644
--- a/src/theme/navigation-menu.ts
+++ b/src/theme/navigation-menu.ts
@@ -15,10 +15,10 @@ export default (config: { colors: string[] }) => ({
     childItem: '',
     childLink: 'group size-full px-3 py-2 rounded-md flex items-start gap-2 text-left',
     childLinkWrapper: 'flex flex-col items-start',
-    childLinkLabel: 'font-semibold text-sm relative inline-flex',
-    childLinkDescription: 'text-sm text-gray-500 dark:text-gray-400',
     childLinkIcon: 'size-5 shrink-0',
-    childLinkExternalIcon: 'size-3 align-top text-gray-400 dark:text-gray-500',
+    childLinkLabel: 'font-semibold text-sm relative inline-flex',
+    childLinkLabelExternalIcon: 'size-3 align-top text-gray-400 dark:text-gray-500',
+    childLinkDescription: 'text-sm text-gray-500 dark:text-gray-400',
     separator: 'px-2 h-px bg-gray-200 dark:bg-gray-800',
     viewportWrapper: 'absolute top-full inset-x-0 flex w-full',
     // FIXME: add `sm:w-[var(--radix-navigation-menu-viewport-width)]` / `transition-[width,height]` / `origin-[top_center]` once position is based on trigger