arthur/ui
1
0
Fork 0
mirror of https://github.com/ArthurDanjou/ui.git synced 2026-01-30 03:38:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(useOverlay): use original props when not provided to open (#4269)

Browse Source
This commit is contained in:
Eugen Istoc
2025-06-05 09:48:47 -04:00
committed by GitHub
parent 09151df170
commit bf56e15a2e
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/runtime/composables/useOverlay.ts
View File

@@ -17,6 +17,7 @@ interface ManagedOverlayOptionsPrivate<T extends Component> {
id: symbol id: symbol
isMounted: boolean isMounted: boolean
isOpen: boolean isOpen: boolean
originalProps?: ComponentProps<T>
resolvePromise?: (value: any) => void resolvePromise?: (value: any) => void
} }
export type Overlay = OverlayOptions<Component> & ManagedOverlayOptionsPrivate<Component> export type Overlay = OverlayOptions<Component> & ManagedOverlayOptionsPrivate<Component>
@@ -26,7 +27,6 @@ type OverlayInstance<T extends Component> = Omit<ManagedOverlayOptionsPrivate<T>
open: (props?: ComponentProps<T>) => OpenedOverlay<T> open: (props?: ComponentProps<T>) => OpenedOverlay<T>
close: (value?: any) => void close: (value?: any) => void
patch: (props: Partial<ComponentProps<T>>) => void patch: (props: Partial<ComponentProps<T>>) => void
} }
type OpenedOverlay<T extends Component> = Omit<OverlayInstance<T>, 'open' | 'close' | 'patch' | 'modelValue' | 'resolvePromise'> & { type OpenedOverlay<T extends Component> = Omit<OverlayInstance<T>, 'open' | 'close' | 'patch' | 'modelValue' | 'resolvePromise'> & {
@@ -37,7 +37,7 @@ function _useOverlay() {
const overlays = shallowReactive<Overlay[]>([]) const overlays = shallowReactive<Overlay[]>([])
const create = <T extends Component>(component: T, _options?: OverlayOptions<ComponentProps<T>>): OverlayInstance<T> => { const create = <T extends Component>(component: T, _options?: OverlayOptions<ComponentProps<T>>): OverlayInstance<T> => {
const { props: props, defaultOpen, destroyOnClose } = _options || {} const { props, defaultOpen, destroyOnClose } = _options || {}
const options = reactive<Overlay>({ const options = reactive<Overlay>({
id: Symbol(import.meta.dev ? 'useOverlay' : ''), id: Symbol(import.meta.dev ? 'useOverlay' : ''),
@@ -45,7 +45,8 @@ function _useOverlay() {
component: markRaw(component!), component: markRaw(component!),
isMounted: !!defaultOpen, isMounted: !!defaultOpen,
destroyOnClose: !!destroyOnClose, destroyOnClose: !!destroyOnClose,
props: props || {} originalProps: props || {},
props: {}
}) })
overlays.push(options) overlays.push(options)
@@ -64,6 +65,8 @@ function _useOverlay() {
// If props are provided, update the overlay's props // If props are provided, update the overlay's props
if (props) { if (props) {
patch(overlay.id, props) patch(overlay.id, props)
} else {
patch(overlay.id, overlay.originalProps)
} }
overlay.isOpen = true overlay.isOpen = true