From 75e4792f7f00c55229253289c4f806f2b6fc9854 Mon Sep 17 00:00:00 2001 From: Benjamin Canac Date: Wed, 23 Apr 2025 16:12:13 +0200 Subject: [PATCH] fix(Accordion): use `div` instead of `h3` for header tag Resolves #3963 --- src/runtime/components/Accordion.vue | 2 +- .../__snapshots__/Accordion-vue.spec.ts.snap | 240 +++++++++--------- .../__snapshots__/Accordion.spec.ts.snap | 240 +++++++++--------- 3 files changed, 241 insertions(+), 241 deletions(-) diff --git a/src/runtime/components/Accordion.vue b/src/runtime/components/Accordion.vue index 65e14d30..4bc6ec09 100644 --- a/src/runtime/components/Accordion.vue +++ b/src/runtime/components/Accordion.vue @@ -98,7 +98,7 @@ const ui = computed(() => tv({ extend: tv(theme), ...(appConfig.ui?.accordion || :disabled="item.disabled" :class="ui.item({ class: props.ui?.item })" > - + diff --git a/test/components/__snapshots__/Accordion-vue.spec.ts.snap b/test/components/__snapshots__/Accordion-vue.spec.ts.snap index 62a2f6dc..3d8a8a95 100644 --- a/test/components/__snapshots__/Accordion-vue.spec.ts.snap +++ b/test/components/__snapshots__/Accordion-vue.spec.ts.snap @@ -3,37 +3,37 @@ exports[`Accordion > renders with as correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -44,37 +44,37 @@ exports[`Accordion > renders with as correctly 1`] = ` exports[`Accordion > renders with as correctly 2`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -85,37 +85,37 @@ exports[`Accordion > renders with as correctly 2`] = ` exports[`Accordion > renders with body slot correctly 1`] = ` "
-

+
-

+
Body slot
-

+
-

+
-

+
-

+
@@ -126,37 +126,37 @@ exports[`Accordion > renders with body slot correctly 1`] = ` exports[`Accordion > renders with class correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -167,37 +167,37 @@ exports[`Accordion > renders with class correctly 1`] = ` exports[`Accordion > renders with collapsible correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -208,35 +208,35 @@ exports[`Accordion > renders with collapsible correctly 1`] = ` exports[`Accordion > renders with content slot correctly 1`] = ` "
-

+
-

+
Content slot
-

+
-

+
-

+
-

+
@@ -247,37 +247,37 @@ exports[`Accordion > renders with content slot correctly 1`] = ` exports[`Accordion > renders with custom body slot correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
Custom body slot
@@ -288,37 +288,37 @@ exports[`Accordion > renders with custom body slot correctly 1`] = ` exports[`Accordion > renders with custom slot correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
Custom slot
" @@ -327,37 +327,37 @@ exports[`Accordion > renders with custom slot correctly 1`] = ` exports[`Accordion > renders with default slot correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -368,37 +368,37 @@ exports[`Accordion > renders with default slot correctly 1`] = ` exports[`Accordion > renders with defaultValue correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -409,37 +409,37 @@ exports[`Accordion > renders with defaultValue correctly 1`] = ` exports[`Accordion > renders with disabled correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -450,37 +450,37 @@ exports[`Accordion > renders with disabled correctly 1`] = ` exports[`Accordion > renders with items correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -491,37 +491,37 @@ exports[`Accordion > renders with items correctly 1`] = ` exports[`Accordion > renders with labelKey correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -532,37 +532,37 @@ exports[`Accordion > renders with labelKey correctly 1`] = ` exports[`Accordion > renders with leading slot correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -573,37 +573,37 @@ exports[`Accordion > renders with leading slot correctly 1`] = ` exports[`Accordion > renders with modelValue correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -614,37 +614,37 @@ exports[`Accordion > renders with modelValue correctly 1`] = ` exports[`Accordion > renders with trailing slot correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -655,37 +655,37 @@ exports[`Accordion > renders with trailing slot correctly 1`] = ` exports[`Accordion > renders with trailingIcon correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -696,37 +696,37 @@ exports[`Accordion > renders with trailingIcon correctly 1`] = ` exports[`Accordion > renders with type correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -737,37 +737,37 @@ exports[`Accordion > renders with type correctly 1`] = ` exports[`Accordion > renders with ui correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -778,37 +778,37 @@ exports[`Accordion > renders with ui correctly 1`] = ` exports[`Accordion > renders with unmountOnHide correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
diff --git a/test/components/__snapshots__/Accordion.spec.ts.snap b/test/components/__snapshots__/Accordion.spec.ts.snap index 9fab65a7..7d1fc68b 100644 --- a/test/components/__snapshots__/Accordion.spec.ts.snap +++ b/test/components/__snapshots__/Accordion.spec.ts.snap @@ -3,37 +3,37 @@ exports[`Accordion > renders with as correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -44,37 +44,37 @@ exports[`Accordion > renders with as correctly 1`] = ` exports[`Accordion > renders with as correctly 2`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -85,37 +85,37 @@ exports[`Accordion > renders with as correctly 2`] = ` exports[`Accordion > renders with body slot correctly 1`] = ` "
-

+
-

+
Body slot
-

+
-

+
-

+
-

+
@@ -126,37 +126,37 @@ exports[`Accordion > renders with body slot correctly 1`] = ` exports[`Accordion > renders with class correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -167,37 +167,37 @@ exports[`Accordion > renders with class correctly 1`] = ` exports[`Accordion > renders with collapsible correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -208,35 +208,35 @@ exports[`Accordion > renders with collapsible correctly 1`] = ` exports[`Accordion > renders with content slot correctly 1`] = ` "
-

+
-

+
Content slot
-

+
-

+
-

+
-

+
@@ -247,37 +247,37 @@ exports[`Accordion > renders with content slot correctly 1`] = ` exports[`Accordion > renders with custom body slot correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
Custom body slot
@@ -288,37 +288,37 @@ exports[`Accordion > renders with custom body slot correctly 1`] = ` exports[`Accordion > renders with custom slot correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
Custom slot
" @@ -327,37 +327,37 @@ exports[`Accordion > renders with custom slot correctly 1`] = ` exports[`Accordion > renders with default slot correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -368,37 +368,37 @@ exports[`Accordion > renders with default slot correctly 1`] = ` exports[`Accordion > renders with defaultValue correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -409,37 +409,37 @@ exports[`Accordion > renders with defaultValue correctly 1`] = ` exports[`Accordion > renders with disabled correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -450,37 +450,37 @@ exports[`Accordion > renders with disabled correctly 1`] = ` exports[`Accordion > renders with items correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -491,37 +491,37 @@ exports[`Accordion > renders with items correctly 1`] = ` exports[`Accordion > renders with labelKey correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -532,37 +532,37 @@ exports[`Accordion > renders with labelKey correctly 1`] = ` exports[`Accordion > renders with leading slot correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -573,37 +573,37 @@ exports[`Accordion > renders with leading slot correctly 1`] = ` exports[`Accordion > renders with modelValue correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -614,37 +614,37 @@ exports[`Accordion > renders with modelValue correctly 1`] = ` exports[`Accordion > renders with trailing slot correctly 1`] = ` "
-

+
-

+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed neque elit, tristique placerat feugiat ac, facilisis vitae arcu. Proin eget egestas augue. Praesent ut sem nec arcu pellentesque aliquet. Duis dapibus diam vel metus tempus vulputate.
-

+
-

+
-

+
-

+
@@ -655,37 +655,37 @@ exports[`Accordion > renders with trailing slot correctly 1`] = ` exports[`Accordion > renders with trailingIcon correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -696,37 +696,37 @@ exports[`Accordion > renders with trailingIcon correctly 1`] = ` exports[`Accordion > renders with type correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -737,37 +737,37 @@ exports[`Accordion > renders with type correctly 1`] = ` exports[`Accordion > renders with ui correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+
@@ -778,37 +778,37 @@ exports[`Accordion > renders with ui correctly 1`] = ` exports[`Accordion > renders with unmountOnHide correctly 1`] = ` "
-

+
-

+
-

+
-

+
-

+
-

+