From 758e6f140068d6a0b5cf62f0ba4b59d7a05b0dd1 Mon Sep 17 00:00:00 2001 From: Benjamin Canac Date: Tue, 20 Dec 2022 16:26:55 +0100 Subject: [PATCH] Revert "chore: put back stop propagation on mode hover (#121)" This reverts commit c015148f298188b2e0a018a62aa86a111e5d3543. --- src/runtime/components/elements/Dropdown.vue | 7 ------- src/runtime/components/overlays/Popover.vue | 7 ------- 2 files changed, 14 deletions(-) diff --git a/src/runtime/components/elements/Dropdown.vue b/src/runtime/components/elements/Dropdown.vue index 7defe027..43527cd6 100644 --- a/src/runtime/components/elements/Dropdown.vue +++ b/src/runtime/components/elements/Dropdown.vue @@ -172,13 +172,6 @@ onMounted(() => { } const menuProvidesSymbols = Object.getOwnPropertySymbols(menuProvides) menuApi.value = menuProvidesSymbols.length && menuProvides[menuProvidesSymbols[0]] - // stop trigger click propagation on hover - menuApi.value?.buttonRef?.addEventListener('click', (e: Event) => { - // ignore links as it would break navigation - if (props.mode === 'hover' && (e.target as Element)?.tagName !== 'A') { - e.stopPropagation() - } - }, true) }, 200) }) diff --git a/src/runtime/components/overlays/Popover.vue b/src/runtime/components/overlays/Popover.vue index dc8f4315..626a2af5 100644 --- a/src/runtime/components/overlays/Popover.vue +++ b/src/runtime/components/overlays/Popover.vue @@ -86,13 +86,6 @@ onMounted(() => { } const popoverProvidesSymbols = Object.getOwnPropertySymbols(popoverProvides) popoverApi.value = popoverProvidesSymbols.length && popoverProvides[popoverProvidesSymbols[0]] - // stop trigger click propagation on hover - popoverApi.value?.button?.addEventListener('click', (e: Event) => { - // ignore links as it would break navigation - if (props.mode === 'hover' && (e.target as Element)?.tagName !== 'A') { - e.stopPropagation() - } - }, true) }, 200) })