fix(Modal): wait for transition to complete to reset state (#1618)

This commit is contained in:
Neil Richter
2024-04-05 14:07:51 +02:00
committed by GitHub
parent b62cd7905d
commit 2bdb5d2b42
3 changed files with 19 additions and 5 deletions

View File

@@ -1,5 +1,5 @@
<template> <template>
<TransitionRoot :appear="appear" :show="isOpen" as="template"> <TransitionRoot :appear="appear" :show="isOpen" as="template" @after-leave="onAfterLeave">
<HDialog :class="ui.wrapper" v-bind="attrs" @close="close"> <HDialog :class="ui.wrapper" v-bind="attrs" @close="close">
<TransitionChild v-if="overlay" as="template" :appear="appear" v-bind="ui.overlay.transition"> <TransitionChild v-if="overlay" as="template" :appear="appear" v-bind="ui.overlay.transition">
<div :class="[ui.overlay.base, ui.overlay.background]" /> <div :class="[ui.overlay.base, ui.overlay.background]" />
@@ -82,7 +82,7 @@ export default defineComponent({
default: () => ({}) default: () => ({})
} }
}, },
emits: ['update:modelValue', 'close', 'close-prevented'], emits: ['update:modelValue', 'close', 'close-prevented', 'after-leave'],
setup (props, { emit }) { setup (props, { emit }) {
const { ui, attrs } = useUI('modal', toRef(props, 'ui'), config, toRef(props, 'class')) const { ui, attrs } = useUI('modal', toRef(props, 'ui'), config, toRef(props, 'class'))
@@ -117,6 +117,10 @@ export default defineComponent({
emit('close') emit('close')
} }
const onAfterLeave = () => {
emit('after-leave')
}
provideUseId(() => useId()) provideUseId(() => useId())
return { return {
@@ -125,6 +129,7 @@ export default defineComponent({
attrs, attrs,
isOpen, isOpen,
transitionClass, transitionClass,
onAfterLeave,
close close
} }
} }

View File

@@ -1,5 +1,11 @@
<template> <template>
<component :is="modalState.component" v-if="modalState" v-bind="modalState.props" v-model="isOpen" /> <component
:is="modalState.component"
v-if="modalState"
v-bind="modalState.props"
v-model="isOpen"
@after-leave="reset"
/>
</template> </template>
<script lang="ts" setup> <script lang="ts" setup>
@@ -8,5 +14,5 @@ import { useModal, modalInjectionKey } from '../../composables/useModal'
const modalState = inject(modalInjectionKey) const modalState = inject(modalInjectionKey)
const { isOpen } = useModal() const { isOpen, reset } = useModal()
</script> </script>

View File

@@ -24,11 +24,13 @@ function _useModal () {
isOpen.value = true isOpen.value = true
} }
function close () { async function close () {
if (!modalState) return if (!modalState) return
isOpen.value = false isOpen.value = false
}
function reset () {
modalState.value = { modalState.value = {
component: 'div', component: 'div',
props: {} props: {}
@@ -53,6 +55,7 @@ function _useModal () {
return { return {
open, open,
close, close,
reset,
patch, patch,
isOpen isOpen
} }