From 2392b4aa405430fc22766f130448a7cc5ced9a3a Mon Sep 17 00:00:00 2001 From: vahid bagheri Date: Thu, 4 Apr 2024 01:48:40 +0330 Subject: [PATCH] fix(Popover/Dropdown): prevent unintended closure on touchstart in mobile devices (#1609) --- src/runtime/components/elements/Dropdown.vue | 4 ++-- src/runtime/components/overlays/Popover.vue | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/runtime/components/elements/Dropdown.vue b/src/runtime/components/elements/Dropdown.vue index 58f9a575..42742c10 100644 --- a/src/runtime/components/elements/Dropdown.vue +++ b/src/runtime/components/elements/Dropdown.vue @@ -182,8 +182,8 @@ export default defineComponent({ } }) - function onTouchStart () { - if (!menuApi.value) { + function onTouchStart (event: TouchEvent) { + if (!event.cancelable || !menuApi.value) { return } diff --git a/src/runtime/components/overlays/Popover.vue b/src/runtime/components/overlays/Popover.vue index ad28ea55..b4ea58fb 100644 --- a/src/runtime/components/overlays/Popover.vue +++ b/src/runtime/components/overlays/Popover.vue @@ -154,8 +154,8 @@ export default defineComponent({ } }) - function onTouchStart () { - if (!popoverApi.value) { + function onTouchStart (event: TouchEvent) { + if (!event.cancelable || !popoverApi.value) { return }