From 1d2e1caaf5edcbad55bc5c3c75da8afc90ab7a94 Mon Sep 17 00:00:00 2001
From: Benjamin Canac <canacb1@gmail.com>
Date: Fri, 12 Apr 2024 17:23:04 +0200
Subject: [PATCH] feat(Button): add `subtle` variant

---
 playground/pages/button.vue                       | 9 +++------
 src/theme/button.ts                               | 5 +++++
 test/components/Button.spec.ts                    | 1 +
 test/components/__snapshots__/Button.spec.ts.snap | 7 +++++++
 4 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/playground/pages/button.vue b/playground/pages/button.vue
index 1a8bd25a..4c411796 100644
--- a/playground/pages/button.vue
+++ b/playground/pages/button.vue
@@ -2,6 +2,7 @@
 import theme from '#build/ui/button'
 
 const sizes = Object.keys(theme.variants.size)
+const variants = Object.keys(theme.variants.variant)
 </script>
 
 <template>
@@ -40,11 +41,7 @@ const sizes = Object.keys(theme.variants.size)
       </UButton>
     </div>
     <div class="flex items-center gap-2">
-      <UButton icon="i-heroicons-rocket-launch" label="Button" />
-      <UButton icon="i-heroicons-rocket-launch" label="Button" variant="outline" />
-      <UButton icon="i-heroicons-rocket-launch" label="Button" variant="soft" />
-      <UButton icon="i-heroicons-rocket-launch" label="Button" variant="ghost" />
-      <UButton icon="i-heroicons-rocket-launch" label="Button" variant="link" />
+      <UButton v-for="variant in variants" :key="variant" icon="i-heroicons-rocket-launch" label="Button" :variant="(variant as any)" />
     </div>
     <div class="flex items-center gap-2">
       <UButton icon="i-heroicons-rocket-launch" label="Button" color="white" />
@@ -79,7 +76,7 @@ const sizes = Object.keys(theme.variants.size)
       <UButton v-for="size in sizes" :key="size" icon="i-heroicons-rocket-launch" :size="(size as any)" />
     </div>
     <div class="flex items-center gap-2">
-      <UButton icon="i-heroicons-rocket-launch" trailing-icon="i-heroicons-chevron-down-20-solid" label="Block" loading block />
+      <UButton icon="i-heroicons-rocket-launch" trailing-icon="i-heroicons-chevron-down-20-solid" label="Block" block />
     </div>
     <div class="flex items-center gap-2">
       <UButton icon="i-heroicons-cloud-arrow-down" label="Button" class="group" :ui="{ leadingIcon: 'group-hover:animate-pulse' }" />
diff --git a/src/theme/button.ts b/src/theme/button.ts
index 20d70684..f1dc573a 100644
--- a/src/theme/button.ts
+++ b/src/theme/button.ts
@@ -16,6 +16,7 @@ export default (config: { colors: string[] }) => ({
       solid: '',
       outline: '',
       soft: '',
+      subtle: '',
       ghost: '',
       link: ''
     },
@@ -87,6 +88,10 @@ export default (config: { colors: string[] }) => ({
     color,
     variant: 'soft',
     class: `text-${color}-500 dark:text-${color}-400 bg-${color}-50 hover:bg-${color}-100 disabled:bg-${color}-50 dark:bg-${color}-950 dark:hover:bg-${color}-900 dark:disabled:bg-${color}-950 focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-${color}-500 dark:focus-visible:ring-${color}-400`
+  })), ...config.colors.map((color: string) => ({
+    color,
+    variant: 'subtle',
+    class: `text-${color}-500 dark:text-${color}-400 ring ring-inset ring-${color}-500/25 dark:ring-${color}-400/25 bg-${color}-500/10 hover:bg-${color}-100 disabled:bg-${color}-50 dark:bg-${color}-400/10 dark:hover:bg-${color}-950 dark:disabled:bg-${color}-400/10 focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-${color}-500 dark:focus-visible:ring-${color}-400`
   })), ...config.colors.map((color: string) => ({
     color,
     variant: 'ghost',
diff --git a/test/components/Button.spec.ts b/test/components/Button.spec.ts
index 858bff82..6c0715e3 100644
--- a/test/components/Button.spec.ts
+++ b/test/components/Button.spec.ts
@@ -15,6 +15,7 @@ describe('Button', () => {
     ['with color', { props: { label: 'Button', color: 'red' as const } }],
     ['with variant outline', { props: { label: 'Button', variant: 'outline' as const } }],
     ['with variant soft', { props: { label: 'Button', variant: 'soft' as const } }],
+    ['with variant subtle', { props: { label: 'Button', variant: 'subtle' as const } }],
     ['with variant ghost', { props: { label: 'Button', variant: 'ghost' as const } }],
     ['with variant link', { props: { label: 'Button', variant: 'link' as const } }],
     ['with icon', { props: { icon: 'i-heroicons-rocket-launch' } }],
diff --git a/test/components/__snapshots__/Button.spec.ts.snap b/test/components/__snapshots__/Button.spec.ts.snap
index 14a42d26..6380afce 100644
--- a/test/components/__snapshots__/Button.spec.ts.snap
+++ b/test/components/__snapshots__/Button.spec.ts.snap
@@ -197,3 +197,10 @@ exports[`Button > renders with variant soft correctly 1`] = `
   <!--v-if-->
 </button>"
 `;
+
+exports[`Button > renders with variant subtle correctly 1`] = `
+"<button type="button" class="rounded-md font-medium inline-flex items-center focus:outline-none disabled:cursor-not-allowed disabled:opacity-75 px-2.5 py-1.5 text-sm gap-x-1.5 text-primary-500 dark:text-primary-400 ring ring-inset ring-primary-500/25 dark:ring-primary-400/25 bg-primary-500/10 hover:bg-primary-100 disabled:bg-primary-50 dark:bg-primary-400/10 dark:hover:bg-primary-950 dark:disabled:bg-primary-400/10 focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-primary-500 dark:focus-visible:ring-primary-400">
+  <!--v-if--><span class="">Button</span>
+  <!--v-if-->
+</button>"
+`;