fix(Slideover): wait for transition to complete to reset state (#1624)

This commit is contained in:
Eugen Istoc
2024-04-05 13:31:29 -04:00
committed by GitHub
parent 9e90d1768b
commit 07a4d13c0f
3 changed files with 13 additions and 4 deletions

View File

@@ -1,5 +1,5 @@
<template> <template>
<TransitionRoot as="template" :appear="appear" :show="isOpen"> <TransitionRoot as="template" :appear="appear" :show="isOpen" @after-leave="onAfterLeave">
<HDialog :class="[ui.wrapper, { 'justify-end': side === 'right' }]" v-bind="attrs" @close="close"> <HDialog :class="[ui.wrapper, { 'justify-end': side === 'right' }]" v-bind="attrs" @close="close">
<TransitionChild v-if="overlay" as="template" :appear="appear" v-bind="ui.overlay.transition"> <TransitionChild v-if="overlay" as="template" :appear="appear" v-bind="ui.overlay.transition">
<div :class="[ui.overlay.base, ui.overlay.background]" /> <div :class="[ui.overlay.base, ui.overlay.background]" />
@@ -71,7 +71,7 @@ export default defineComponent({
default: () => ({}) default: () => ({})
} }
}, },
emits: ['update:modelValue', 'close', 'close-prevented'], emits: ['update:modelValue', 'close', 'close-prevented', 'after-leave'],
setup (props, { emit }) { setup (props, { emit }) {
const { ui, attrs } = useUI('slideover', toRef(props, 'ui'), config, toRef(props, 'class')) const { ui, attrs } = useUI('slideover', toRef(props, 'ui'), config, toRef(props, 'class'))
@@ -109,6 +109,10 @@ export default defineComponent({
emit('close') emit('close')
} }
const onAfterLeave = () => {
emit('after-leave')
}
provideUseId(() => useId()) provideUseId(() => useId())
return { return {
@@ -117,6 +121,7 @@ export default defineComponent({
attrs, attrs,
isOpen, isOpen,
transitionClass, transitionClass,
onAfterLeave,
close close
} }
} }

View File

@@ -4,6 +4,7 @@
v-if="slideoverState" v-if="slideoverState"
v-bind="slideoverState.props" v-bind="slideoverState.props"
v-model="isOpen" v-model="isOpen"
@after-leave="reset"
/> />
</template> </template>
@@ -13,5 +14,5 @@ import { useSlideover, slidOverInjectionKey } from '../../composables/useSlideov
const slideoverState = inject(slidOverInjectionKey) const slideoverState = inject(slidOverInjectionKey)
const { isOpen } = useSlideover() const { isOpen, reset } = useSlideover()
</script> </script>

View File

@@ -24,11 +24,13 @@ function _useSlideover () {
isOpen.value = true isOpen.value = true
} }
function close () { async function close () {
if (!slideoverState) return if (!slideoverState) return
isOpen.value = false isOpen.value = false
}
function reset () {
slideoverState.value = { slideoverState.value = {
component: 'div', component: 'div',
props: {} props: {}
@@ -53,6 +55,7 @@ function _useSlideover () {
return { return {
open, open,
close, close,
reset,
patch, patch,
isOpen isOpen
} }