[PR #1] [MERGED] refactor: runtime config #2

New Issue

arthur · 2025-12-01T17:04:26+01:00

arthur commented

2025-12-01 17:04:26 +01:00

📋 Pull Request Information

Original PR: https://github.com/ArthurDanjou/artsite/pull/1
Author: @Barbapapazes
Created: 6/23/2024
Status: ✅ Merged
Merged: 6/23/2024
Merged by: @ArthurDanjou

Base: master ← Head: refactor/runtime-config

📝 Commits (1)

e863ab2 refactor: runtime config

📊 Changes

3 files changed (+22 additions, -16 deletions)

View changed files

📝 nuxt.config.ts (+13 -9)
📝 server/api/activity.get.ts (+2 -2)
📝 server/api/stats.get.ts (+7 -5)

📄 Description

Because of some typos, you will have to update your environment variables in your deployment like the USER_UD instead of the USER_ID

Hello 👋,

I refactor the usage of the runtime config. First, there was some typos between the name of the environment variable and the name of the runtime config. Then, I remove the usage of process.env since Nuxt is already able to overwrite the runtime config with the environment variables.

You can learn more with this video: https://youtu.be/_FYV5WfiWvs?si=XWUumfMOBC90TivF

I think the runtime config discord.id and discord.token is not used and could be removed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArthurDanjou/artsite/pull/1 **Author:** [@Barbapapazes](https://github.com/Barbapapazes) **Created:** 6/23/2024 **Status:** ✅ Merged **Merged:** 6/23/2024 **Merged by:** [@ArthurDanjou](https://github.com/ArthurDanjou) **Base:** `master` ← **Head:** `refactor/runtime-config` --- ### 📝 Commits (1) - [`e863ab2`](https://github.com/ArthurDanjou/artsite/commit/e863ab2901aae066c1e3c46c34c155099db9b81a) refactor: runtime config ### 📊 Changes **3 files changed** (+22 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `nuxt.config.ts` (+13 -9) 📝 `server/api/activity.get.ts` (+2 -2) 📝 `server/api/stats.get.ts` (+7 -5) </details> ### 📄 Description **Because of some typos, you will have to update your environment variables in your deployment like the USER_UD instead of the USER_ID** Hello 👋, I refactor the usage of the runtime config. First, there was some typos between the name of the environment variable and the name of the runtime config. Then, I remove the usage of `process.env` since Nuxt is already able to overwrite the runtime config with the environment variables. You can learn more with this video: https://youtu.be/_FYV5WfiWvs?si=XWUumfMOBC90TivF I think the runtime config `discord.id` and `discord.token` is not used and could be removed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

arthur added the pull-request label 2025-12-01 17:04:26 +01:00

arthur referenced this issue

2025-12-01 17:04:26 +01:00

[PR #2] [MERGED] fix: use use-fetch to avoid to refetch during hydration #3

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: arthur/artsite#2